Sheffield | 26-Jan-ITP | Karim Mhamdi | Sprint 1 | Coursework/sprint-1 by KKtech06 · Pull Request #1092 · CodeYourFuture/Module-Structuring-and-Testing-Data

KKtech06 · 2026-02-27T23:24:15Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist: Improved comments and explanations following review feedback.

I have completed all the tasks for the Sprint-1 and i have created a branch Coursework/Sprint1

Questions

N/A

Sprint-1/1-key-exercises/1-count.js

cjyuan · 2026-02-28T14:52:35Z

Sprint-1/1-key-exercises/3-paths.js

-const dir = ;
-const ext = ;
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = filePath.slice(filePath.lastIndexOf("."))       ;


Code is correct.

On line 21, there are some trailing space characters.
Trailing spaces do not affect program execution, but they can influence how Git detects changes in a file.

If you enabled "Format on save" in VSCode, and you have installed "prettier" extension, VSCode can automatically indent the code and remove all trailing space characters.

You didn't remove the extra trailing space.

Have you follow the recommended setup described in https://github.com/KKtech06/Module-Structuring-and-Testing-Data/blob/main/readme.md?

Sprint-1/1-key-exercises/4-random.js

Sprint-1/2-mandatory-errors/2.js

Sprint-1/3-mandatory-interpret/1-percentage-change.js

Sprint-1/3-mandatory-interpret/2-time-format.js

cjyuan · 2026-02-28T15:46:28Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+// 4. Takes everything except the last 2 digits as pounds.
+// 5. Prints the result in this format: £3.99


(4) and (5) does not quite describe the code on lines 14-16.

Also, could we expect this program to work as intended for any valid penceString if we deleted .padEnd(2, "0") from the code?
In other words, do we really need .padEnd(2, "0") in this script?

#1092 (comment)
This comment was not yet addressed.

Sprint-1/4-stretch-explore/chrome.md

cjyuan

Most changes look good, but you may have missed some of my comments.

Also, it would help me tracked the changes if you can reply directly in each of the inline comments.

cjyuan · 2026-03-02T21:17:57Z

Sprint-1/1-key-exercises/3-paths.js

-const dir = ;
-const ext = ;
+const dir = filePath.slice(0, lastSlashIndex);
+const ext = filePath.slice(filePath.lastIndexOf("."))       ;


You didn't remove the extra trailing space.

Have you follow the recommended setup described in https://github.com/KKtech06/Module-Structuring-and-Testing-Data/blob/main/readme.md?

Sprint-1/2-mandatory-errors/2.js

cjyuan · 2026-03-02T21:22:41Z

Sprint-1/3-mandatory-interpret/3-to-pounds.js

+// 4. Takes everything except the last 2 digits as pounds.
+// 5. Prints the result in this format: £3.99


#1092 (comment)
This comment was not yet addressed.

cjyuan · 2026-03-02T23:01:22Z

Changes are good! Well done!

Completed Sprint 1

288786a

KKtech06 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026

This comment has been minimized.

Sign in to view

KKtech06 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 27, 2026

KKtech06 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 28, 2026

cjyuan reviewed Feb 28, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 28, 2026

Fixed syntax explanations and improved code comments

19ad2a1

KKtech06 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 2, 2026

cjyuan reviewed Mar 2, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026

Improved errors based on feedback

2276300

KKtech06 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 2, 2026

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 2, 2026

		// 4. Takes everything except the last 2 digits as pounds.
		// 5. Prints the result in this format: £3.99

Uh oh!

Conversation

KKtech06 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist: Improved comments and explanations following review feedback.

Questions

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

cjyuan Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjyuan Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KKtech06 commented Feb 27, 2026 •

edited

Loading